Review of "invertDE" version 3

Details Page Preview

Invert color the whole Gnome Desktop Environment for reading purposes. This extention use xcalib program for inverting the color, so you need to install xcalib first( in debian-based ditro you can use 'sudo apt-get install xcalib').

Extension Homepage
https://github.com/saaie/invertDE

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Carlos active
Looks good now!
Carlos rejected
Sorry, I approved the wrong extension. In this, when you disable the extension, if the user activated the xcalib, and you disable the extension the extension should put xcalib as how it was before (deactivated by default).
Amin Khozaei posted a review
Hi csoriano, What do you mean? My extension required xcalib for change color, if xcalib not installed this extension not work. You mean i shouldn't use xcalib?
Carlos posted a review
Saaie, Sorry I didn't explain it well. Imagine the user install and enable the extension. The user activate the button, xcalib is called and the color change. Then the user disable the extension. But the color remains inverted, so the state of the computer is not the same as previous of installing the extension. You have to avoid that. when disable() is called, make sure the state of the colors is the same as previous installing the extension. For example make a variable enabled = false for the first time, and change it every time toggleInvert is called. Then in disable() make a condition like if (enabled) { toggleInvert(); } to reset the state.