Review "Ubuntu Kiosk Mode" version 1 - GNOME Shell Extensions

Review of "Ubuntu Kiosk Mode" version 1

Details Page Preview

Ubuntu Kiosk Mode

by srleohung

Disables gestures, onscreen keyboard, menu bar, and top bar for kiosks and touch screen apps.

Extension Homepage: https://github.com/srleohung/ubuntu-kiosk-mode-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
1	Rejected

Previous Reviews on this Version

srleohung posted a review March 29, 2023

JustPerfection rejected March 29, 2023

1. `settings-schema` in metadata.json should be string. That's what `extensionUtils` is using: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/d7d26e8c59be54298545d6833656254a0f2f4821/js/misc/extensionUtils.js#L213 2. You are doing too much logs and prints. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 3. No need for line 32 (prefs.js) in 3.36 and higher. 4. What are you trying to do in prefs exactly? Just echoing those commands? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions