Review of "Dejaview" version 2

Details Page Preview

Show a notification with a chosen frequency

Extension Homepage
https://github.com/hedgieinsocks/gnome-extension-dejaview

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init (line 16 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Also you have this error since you are adding it there while it is aleadey there: ``` JS ERROR: Error: Extension point conflict: there is already a status indicator for role Dejaview addToStatusArea@resource:///org/gnome/shell/ui/panel.js:721:19 _addTimer@/home/ice/.local/share/gnome-shell/extensions/dejaview@hedgie.tech/extension.js:140:20 _startTimer@/home/ice/.local/share/gnome-shell/extensions/dejaview@hedgie.tech/extension.js:155:18 enable/<@/home/ice/.local/share/gnome-shell/extensions/dejaview@hedgie.tech/extension.js:200:22 ``` 3. I don't think it works properly on lock though. when the lock is happening, all extensions get disabled, then the ones with `unlock-dialog` session mode is getting re-enabled. so, the timer will be wrong (and not running?).
hedgie waiting for author
Thank you for your time and advice! 1. Should I do it like this? ``` enable() { this._settings = ExtensionUtils.getSettings(); ``` 2. I do not observe such an error while trailing logs via journalctl -f -o cat /usr/bin/gnome-shell but perhaps I've made some changes already to fix it without even knowing about it. I guess we'll find it out in the upcoming reviews. 3. I've added a simple log message to disable() function and faced some weird situation. Here is how it looks: - disable extension - reload shell - enable extension - start timer - lock the screen and see that timer is off like it is properly stopped (not active quick settings button + no indicator in panel) - see in logs that the extension got disabled/enabled 4 times in a row - lock the screen again and see that the timer stays on, it works properly in the lock screen and after it, and after all other lock/unlock attempts as well - see in logs no disable/enable events - same situation after a reboot or re-login Is it expected that extensions on lock event get switched off and on only the first time after being enabled on a fresh shell? And if so, why 4 times? --- Please clarify, should I keep uploading fixed versions as I did with versions 2 and 3? And if yes, should I increment the version in metadata.json?
JustPerfection rejected
# 1 Yes, then null that out in disable. # 3 That's the expected behavior. I also recommend to remove session modes and don't use it in your extension since that's not what you want. I recommend to join the Matrix channel and read the recent chat about the session modes: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions and version is auto increment here. any version you post here will be +1.