Review of "App Hider" version 1

Details Page Preview

Hide app icons and search entries in GNOME's (42+) overview.

Extension Homepage
https://github.com/LynithDev/gnome-app-hider

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Bad schemas id, path and filename: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas 2. Constructor of the instance that init returns is doing too much (line 10-13 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 3. Also do this in disable: ```js this.appMenuPatcher = null; this.appDisplayPatcher = null; this.settings = null; ``` 4. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 5. Don't create more than one gsettings instances. Create one in extension.js and use dependency injection for the classes and functions that needed that. - line 13 patches/appDisplayPatcher.js - line 22 patches/appMenuPatcher.js 6. No need to do that in gtk 4 (line 18 prefs.js). and `buildPrefsWidget()` won't get triggered if you use `fillPreferencesWindow()`: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#prefs so delete `buildPrefsWidget()` 7. Remove `.github` folder: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions