Review of "Slingshot" version 1

Details Page Preview

A clone of Pantheon's Slingshot launcher in the form of a GNOME Shell extension.


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author
Make sure that your signals get disconnect.
jfarthing84 posted a review
Which signals need to be disconnected? Each signal connected to actors I create?
Meng Zhuo waiting for author
Yes, ALL of them.
jfarthing84 posted a review
Seriously? After reviewing ALL of the extensions in the OFFICIAL extensions package (https://git.gnome.org/browse/gnome-shell-extensions), all connected signals are not disconnected in any of them.
Meng Zhuo waiting for author
I know. After Button or UI destroyed, it wouldn't trigger any functions, but anonymous functions still in memory and can't be GC. Disconnect signals that attached to none UI object (like this.appSystem) is mandatory, others is suggested.
jfarthing84 posted a review
I've updated the extension to remove the app system signals. However, I don't see how to update it on here. See https://github.com/jfarthing84/gnome-slingshot
Meng Zhuo waiting for author
You have to upload a newer version and reject this version.
jfarthing84 posted a review
New version incoming.
jfarthing84 rejected