Review of "French Republican Calendar" version 1

Details Page Preview

Displays the French Republican Calendar in the top panel


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author
Please make sure any connected signal disconnected
jcdubacq posted a review
I may be mistaken (I am new to this), but apart from St.buttons, my only "connection" is the timeout, which is disconnected in the destroy method. I hope that buttons disconnect themselves in their own destroy method! That would be silly not doing that. If I did oversee something, do not hesitate to tell me!
Meng Zhuo waiting for author
The connect function will return a signal ID, then you can disconnect it. here is an simple example in your code: moreButtonChangeSignal = this._morebackButton.connect('clicked', Lang.bind(this, function() { this.changeOffset(-30,true); })); in disable function: this._morebackButton.disconnect(moreButtonChangeSignal)
jcdubacq posted a review
This should be fixed in version 3 of the extension, uploaded now. The localization thing did not work anyway on this one. The http://blog.mecheye.net/2012/02/requirements-and-tips-for-getting-your-gnome-shell-extension-approved/ page spoke of global signals assignments, so I thought buttons would know enough that they would disconnect their own signals when destroyed. My bad :)
Meng Zhuo rejected
reject for newer version