Review of "Input method and touchpad shortcuts" version 1

Details Page Preview

Quick switching of input method and touchpad with user configurable shortcut binding

Extension Homepage
https://github.com/osamuaoki/inputmethod-shortcuts

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `stylesheet.css` since you are not using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Remove versions >=45 since we don't have those versions yet. 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 4. That's too much for init (line 42 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization Move that line to enable and null that out in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 5. Remove all the key bindings on disable (line 118-149 extension.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions