Review of "Open Browser Tabs on Active Workspace" version 3

Details Page Preview

Open tabs on active workspace.

Extension Homepage
https://github.com/janhouse/tab-in-workspace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Name caps issue (org.gnome.Shell.Extensions) in line 26. 2. What is `lv.janhouse.TabInWorkspace.Browser` (line 35 extension.js)? 3. Remove the timeout on disable or destroy (line 106 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Janhouse posted a review
1. - not an issue, that is the actual d-bus interface name. 2. - that is d-bus interface for the firefox native messaging host of the plugin ( https://github.com/Janhouse/tab-in-workspace ) Firefox extension is here: https://addons.mozilla.org/en-US/firefox/addon/open-on-active-desktop/ 3. ok, but those are short lived timeouts and returning `false` destroys it.
JustPerfection posted a review
For #3, as we stated in the doc: > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. Because timeouts can get delayed and the callback get triggered in unlock screen.