Review of "Show Public IP" version 6

Details Page Preview

Simple GNOME Shell Extension that shows your current public IP address. It's retrieved by a curl command to ip.elcamilet.com

Extension Homepage
https://github.com/elcamilet/show-ip-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
17 Active
16 Rejected
15 Rejected
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Rejected
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
JustPerfection rejected
oh, that is wrong. you should use `this._sourceId` and remove that on disable.
Camilo Nevot waiting for author
Something like this? constructor() { this._sourceId = null; } disable() { if (this._sourceId) { GLib.Source.remove(this._sourceId); } this._sourceId.destroy(); this._sourceId = null; }
JustPerfection rejected
```js constructor() { this._sourceId = null; } enable() { let this._sourceId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 60, () => { // ... }); } disable() { if (this._sourceId) { GLib.Source.remove(this._sourceId); this._sourceId = null; } } ```
JustPerfection posted a review
Sorry for that. I mean without `let`: ```js enable() { this._sourceId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 60, () => { } ```
Camilo Nevot posted a review
I know ;) Thanks a lot for your support and patience!