Review "such doge" version 1 - GNOME Shell Extensions

Review of "such doge" version 1

Details Page Preview

such doge

by turupawn

Shows random doge messages every time you hit the dogecoin button.

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

Meng Zhuo waiting for author October 8, 2014

So it just an example you copied?

turupawn posted a review October 8, 2014

Hi mengzhuo, Thanks for reviewing my first extension. I used https://github.com/csoriano89/StepByStepTutorial as reference and put it on the first line of comments of extension.js. The extension has a twist for the dogecoin comunity. I implemented some changes and documented them on the comments. Here the difference beetween the original work and mine: http://pastebin.com/wyh78p5x

Meng Zhuo waiting for author October 8, 2014

I see However I SUGGEST you disconnect "button-press-event" signal in disable function to meet the standard http://blog.mecheye.net/2012/02/requirements-and-tips-for-getting-your-gnome-shell-extension-approved/

turupawn posted a review October 8, 2014

I just uploaded a new version where it disconnects the "button-press-event" signal using: button.disconnect(buttonPressId); Where buttonPressId is previously saved when the connection is made.

Meng Zhuo rejected October 8, 2014

Reject for newer version