Review of "Custom Magnifier" version 2

Details Page Preview

Change GNOME magnification using <Alt>KP_Subtract and <Alt>KP_Add.

Extension Homepage
https://github.com/garfunkel/gnome-shell-extension-custom-magnifier

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove old 3.x versions if you didn't test this package in those versions. 2. Use "40" instead of "40.0". Same for all 4x versions. 3. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 4. Use `ExtensionUtils.getSettings()` instead of creating your own custom function (line 1-11 extension.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 5. Import at the top of the file instead of inside functions (for example, line 14 extension.js). 6. Please make `settings` global and null it out in disable (line 22 extension.js). `settings` won't get garbage collected if you do that since `wm.addKeybinding` is holding it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions