Review of "Activity App Launcher" version 38

Details Page Preview

Integrates a category-based application launcher in the activities window. IMPORTANT: it needs the 'gnome-menus' and 'libgnome-menu-3-dev'; they must be installed in the system before installing this extension.

Extension Homepage
https://gitlab.com/rastersoft/activityAppLauncher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Don't use generic name for the class you are exporting (line 8 prefs.js). 2. Also do this in disable: ```js this._appSys = null; this._settings = null; this._appsInnerContainer = null; this.selected = null; this._favorites = null; ``` 3. You should make settings local (line 11 prefs.js) because that won't get garbage collected. attach it to the window after madking it local: ```js window._settings = this.getSettings(); ``` You can pass settings to the methods needed that. For example: ```js buildSwitcher(key, labeltext, settings) { // ^^^^^^^^ ``` 4. Unused method (line 54 prefs.js). 5. Also disconnect that on disable (line 74 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 6. What's the reason for `this.isEnabled` (line 189 extension.js)? As we stated in the review guidelines: > Extensions MUST NOT disable selectively. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes