Review of "Cloudflare Warp Toggle" version 6

Details Page Preview

Toggle cloudflare warp in quick settings. This extension depends on warp-cli parsing. To quickly get started, Read the Docs: https://github.com/khaled-0/gnome-cloudflare-warp-toggle#readme This extension is not affiliated, funded, or in any way associated with Cloudflare. To Setup warp-cli, follow the official guide: https://developers.cloudflare.com/warp-client/get-started/linux/

Extension Homepage
https://github.com/khaled-0/gnome-cloudflare-warp-toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You shouldn't use the same name for timeout, so you can remove both on disable (line 17 and 29 extension.js)
khaled-0 posted a review
But the first timeout gets cancelled before the second timeout is set. To me, It doesn't make sense to use a separate variable for the exact same timeout function. But if you still believe that's a possible issue then please brief me on what I should do. Thanks.
JustPerfection posted a review
That can make the review process harder though. They are the same but defined multiple times. You can create a method that can start the timeout for you. ```js startCheck() { if (this._timeout) clearInterval(this._timeout); this._timeout = setInterval( () => this._indicator.checkStatus(), this._settings.get_uint("status-check-freq") * 1000 ); } ```