Review "Custom Window Controls" version 1

Review of "Custom Window Controls" version 1

Details Page Preview

Custom Window Controls

by icedman

Theme the window control buttons. (Warning: Highly Experimental)

Extension Homepage: https://github.com/icedman/custom-window-controls

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
8	Active
7	Rejected
6	Active
5	Active
4	Rejected
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected September 23, 2023

1. Not necessary (line 34 prefs.js). 2. Use `this.path` instead of `this.dir.get_path()`. 3. You didn't disconnect object for lines 146, 186 and 193 (extension.js). 4. Also null out these in disable: ```js button_style = null; this._windows = null; ``` 5. Don't use `log()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 6. Don't use github in line 8-9 (client.js).

JustPerfection posted a review September 23, 2023

7. Don't use `byteArray` (line 16 dbus/services.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder