Review "Shrink message tray" version 1

Review of "Shrink message tray" version 1

Details Page Preview

Shrink message tray

by ericwork

Reduces the height of the message tray

Extension Homepage: https://github.com/zeroepoch/gnome-shell-extension-shrink-message-tray

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
2	Active
1	Active

Previous Reviews on this Version

Meng Zhuo waiting for author November 29, 2014

You should undo in disable function

ericwork posted a review November 29, 2014

I read the tips for extension approval and I figured this was going to be an issue. I can change the icon size back obviously in disable(), but doing so would break things. The container for the icon would then be smaller than the icon source. While it doesn't crash the shell when you do this, it does create some UI inconsistencies. The corresponding CSS changes only happen when the extension is loaded (and I don't know how to undo the CSS changes) so it only made sense to have the other UI changes follow suit. I created this extension mainly to avoid hacking the gnome-shell CSS and JS files because it was painful every package upgrade and thought others might find it useful. If such a change is not appropriate for this website I guess that's fine.

Meng Zhuo active December 1, 2014

OK