Review of "Gradient Top Bar" version 12

Details Page Preview

Makes GNOME's panel's background gradient. You can edit the colour scheme from the extension's settings in Gnome 45+.

Extension Homepage
https://github.com/petar-v/gradienttopbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

pshow73 posted a review
JustPerfection rejected
1. Wrong gsettings instance (line 171 extension.js). You should use `this._settings` instead. 2. What is the reason for checking (line 146 extension.js)? Makes any issues if you don't do that? I'm asking that because it is like checking if the extension is enabled or not which is not a good practice and that can be bad in racy situations.
pshow73 posted a review
Hi! Thank you for the review! To address the points: 1. You are right! This is my bad, I will correct that. Nice catch! 2. This is not checking if the extension is enabled, but rather if there is a CSS class applied to the Panel. There is a setting that you can toggle that makes it so that the effect is not applied when there is a maximized window. In case this function is called too many times, it can result in the class being applied twice. I don't know what the effects of that might be but this is a just-in-case thing. I have done some more refactoring work on this but it is in another PR (https://github.com/petar-v/gradienttopbar/pull/27). I will submit a fix for those issues. I will fix the this._settings thing and rename the variable to make its purpose clearer! Thanks again! :)