Review of "Autohide Volume" version 5

Details Page Preview

Autohide volume indicator when muted

Extension Homepage
http://github.com/t184256/gnome-shell-extension-autohide-volume

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove line 18 extension.js, not needed. 2. Please also remove the source id in disable (line 21 extension.js). `idle_add()` is also a timeout: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
t184256 posted a review
> 1. Please remove line 18 extension.js, not needed. Will do. > 2. Please also remove the source id in disable (line 21 extension.js). Will do. > `idle_add()` is also a timeout I'm afraid I don't understand this statement. Best request interpretation I can draw from this is "use .timeout_add(GLib.PRIORITY_DEFAULT_IDLE, ...) and some timeout", please explain in more specific terms if I misunderstood that one.
JustPerfection posted a review
```js this._sourceId = GLib.idle_add(GLib.PRIORITY_DEFAULT, (() => { ``` then: ```js if (this._sourceId) { GLib.Source.remove(this._sourceId); this._sourceId = null; } ```