Review of "Alternate Menu for Hplip2" version 12

Details Page Preview

control your hp printers by calling the device manager hp-toolbox, also some useful links Motivation: the hp-systray doesn't work reliably under gnome shell you need to have installed hplip in order to use this Choice of using a printer icon or a hp_logo.png if it's installed in the same place as mine on Ubuntu you could use symbolic links to fake the path. This is a replacement for the old "Alternate Menu for Hplip" which doesn't work under the new Gome-Shell I have cleaned it up a bit and it has a few new menu's but it is still basically the same thing. Added even more menus all most all system settings ones. New: the menu will be too big if your resolution is way too low like 800x600 I have implemented a compact option in the settings, if you use it the menu will become a two colomn compact format and will fit even on such a low resolution. Dutch language support added by Vistaus (Heimen Stoffels) https://github.com/Vistaus In the past you needed to restart gnome-shell after upgrades so either reboot, log out and back in again, or if your using X11 then alt+F2 then run r; But that should be good now in most cases.

Extension Homepage
https://github.com/grizzlysmit/hplip-menu2-grizzlysmit.smit.id.au

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please don't leave unnecessary comments. for example, line 11 extension.js. same in prefs.js. 2. Everything you store as `this.` in `HpExtensionPreferences` (prefs.js), won't allow the garbage collector do its job after window close. 3. Please remove version from the import (line 18 prefs.js). 4. You cannot do `sudo` in extensions: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#privileged-subprocess-must-not-be-user-writable 5. Also null out `this.cmds` in disable.
grizzly@smit.id.au posted a review
re 2. will storing them against window. /this._window. solve this problem
grizzly@smit.id.au posted a review
re 2. will storing them against window. /this._window. solve this problem
grizzly@smit.id.au posted a review
re 2. didn't work anyway so trying window.connect("destroy", this._on_destroy.bind(this));