Review of "Auto select headset" version 8

Details Page Preview

Auto selects headsets when possible instead of showing a dialog

Extension Homepage
https://github.com/josephlbarnett/autoselectheadset-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
You should remove the source id in disable (line 59 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources On enable: ```js this.#sourceId = GLib.idle_add(GLib.PRIOIRTY_DEFAULT, () => { ``` on disable: ```js if (this.#sourceId) { GLib.Source.remove(this.#sourceId); this.#sourceId = null; } ```