Review of "Perma Clip" version 1

Details Page Preview

Add up to 10 strings to clipboard permanently. Useful for quickly pasting passwords.

Extension Homepage
https://github.com/TheGregster1111/perma-clip

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `getSettings()` function (line 30 extension.js and 20 prefs.js). Use `extensionUtils.getSettings()` instead. 2. Please fix the indentations: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice 3. You cannot import `Adw` to the shell process (line 4 extension.js). 4. Move line 16 (extension.js) to enable and null that out in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 5. Import at the top of the code (line 60 extension.js). It can make the 45 port easier. 6. Timeout should be removed on disable (line 68 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 7. Remove line 76-78 (extension.js). Not needed inside the callback. returning `GLib.SOURCE_REMOVE` would be enough. 8. Please remove unused function (line 87 extension.js). 9. Also null out these in disable: ```js scrollView = null; menu = null; virtualKeyboard = null; ``` 10. Please remove line 1 (prefs.js). Not needed since that has been specified in the parent module. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Susannedev waiting for author
Hello, I believe I have now addressed most of the issues. I have uploaded the new version to the GitHub page. I am however unsure what you mean with 2 and 5. I can't find any issues with the indentation, and I am unsure what I am meant to import.
JustPerfection posted a review
#2 For example, compare line 130 and 131 extension.js. #5 Do this at the top of the code: ```js const ExtensionUtils = imports.misc.extensionUtils; ``` and do this in line 60 instead: ```js ExtensionUtils.openPrefs(); ```
Susannedev posted a review
I believe both issues are now addressed. The new code is on GitHub. What should I do now? Should I re-upload the extension via the "Add yours" menu? Sorry for my confusion, this is my first extension.
JustPerfection rejected
Yes, you can upload the next one the same way you posted this one.