Review of "Vertical Window List" version 10

Details Page Preview

Displays opened windows in vertical panel with productivity perks - left click to open favorites / activate window / activate previous window - right click to close window - middle click to rename window / open extension settings - drag-and-drop to re-arrange windows - mouse wheel to cycle windows Useful for large displays. Adjustable panel width, transparency and other settings

Extension Homepage
https://gitlab.com/student/vertical-window-list

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Rejected
12 Rejected
11 Active
10 Rejected
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Not a good practice (line 1 and 12 prefs.js). It's better to just export default class line 12. You have the same issue in extension.js (line 1, 29, 31, 33, 35) 2. Use a less generic name for the class you are exporting (for stack trace). 3. No need to return (line 580 extension.js). 4. Eveyrthing you store as `this.` in `VWLExtension` (line 35 extension.js), should be null out in disable. I recommend to move all othose methods to another class and just use enable and disable in the default class you are exporting. In that case, you don't need to null out too many properties. You can pass `this` to that class as dependency injection. 5. Use `this.openPreferences()` instead of spawn command (line 219 extension.js): https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils 6. `var` is bad. Use `let` or `const` instead.