Review of "Executor" version 24

Details Page Preview

Execute multiple shell commands periodically with separate intervals and display the output in gnome top bar.

Extension Homepage
https://github.com/raujonas/executor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Make it local to the method so it can be garbage collected after window close (line 20 prefs.js). 2. Timeouts should be removed on disable (line 50, 201, 214, 294 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
JustPerfection posted a review
3. Use `console.*` instead of `log()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging
raujonas posted a review
Hi, thanks for the review. In (1), do you mean to make the settings object local? Then I'd have to pass it to the other methods that are using it, is that correct?
raujonas waiting for author
Hi, thanks for the review. In (1), do you mean to make the settings object local? Then I'd have to pass it to the other methods that are using it, is that correct?
JustPerfection posted a review
Yes.
JustPerfection rejected