Review of "Task Widget" version 17

Details Page Preview

Display tasks next to the calendar widget. Visit our Wiki page for more information and troubleshooting.

Extension Homepage
https://gitlab.com/jmiskinis/gnome-shell-extension-task-widget

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Juozas Miskinis posted a review
I started using a code formatter, hence the abundance of changes. In reality, only minor adjustments were made according to the port guide on gjs.guide. Thank you for reviewing this.
JustPerfection rejected
1. You should remove the timeouts on disable (line 344 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Don't use imports in 45 extensions: - line 11 utils.js - line 30 extension.js - line 22 prefs.js 3. `Extension.lookupByURL()` is a bad practice (line 42 extension.js, line 71 prefs.js). You should use `this.getSettings()` in the entry point and pass it to the class instances (dependency injection).