Review of "Yakuake" version 10

Details Page Preview

A Gnome shell extension to use Yakuake on Gnome. Adds a global shortcut to show/hide yakuake and makes the console appear focussed.

Extension Homepage
https://github.com/albertvaka/yakuake-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add `settings-schema` key to `metadata.json` so you don't need to use the schema id for `this.getSettings()`: https://gjs.guide/extensions/overview/anatomy.html#settings-schema 2. Please make it local (line 10 prefs.js). You can attach it to the `winodw._settings` to avoid garbage collecting before window close. 3. Please remove line 9-12 `extension.js`. Not needed. 4. Null out `this._proxy` in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 5. Please use a better name for the shortcut (line 25 extension.js).
JustPerfection posted a review
#3 and #5 are just a recommendation though.