Review of "Always Show Titles In Overview" version 24

Details Page Preview

Customize Gnome 3 overview. - Always show titles of all window thumbnails - Always show close buttons of all window thumbnails - Window titles position (Bottom, Center) - Move window titles to the bottom when fullscreen - Move window titles to the bottom for video/TV players, like SMPlayer - Show/hide app icons - App icon position: Bottom, Center - Show/hide the app icon when a window is in fullscreen mode - Show/hide the background - Hide/show icons for Video/TV players, like SMPlayer - Tweak the window thumbnail active size increment (from 5 to 60, the default is 15) - Hide the background

Extension Homepage
https://github.com/nlpsuge/Always-Show-Titles-In-Overview

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Rejected
12 Active
11 Inactive
10 Active
9 Active
8 Inactive
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please use a less generic name for the default class you are exporting (for stack trace). 2. Extensions cannot use `run_dispose()` (line 343 extension.js, line 124 workspace.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 3. It's better for `CustomWorkspace` to recieve the settings from the entry point, instead of creating another instance in line 102 (workspace.js).
5q0Fw posted a review
Hi, For 2, can I just remove line line 343 in extension.js and line 124 in workspace.js? Maybe setting _settings to null is enough?
JustPerfection posted a review
Yes, just nulling them out is enough.