Review of "Simple System Monitor" version 15

Details Page Preview

Show current CPU usage, memory usage and net speed on panel. For best experience, please use monospaced font. This is a fork of https://extensions.gnome.org/extension/4478/net-speed/.

Extension Homepage
https://github.com/LGiki/gnome-shell-extension-simple-system-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `lookupByUUID()` is a bad practice (line 323 extension.js). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 2. Use `export class` instead of `export var`. 3. Make it local to `fillPreferencesWindow()` (line 73 prefs.js). 4. Don't store any instance in global scope since that cannot get garbage collected after window close (line 70 prefs.js). 5. Don't use the same property name for the timeout ids (line 410 and 535 extension.js). 6. Please use `TextDecoder` instead of `byteArray` (line 34 extension.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder