Review of "Kube Config" version 24

Details Page Preview

Switches kube config context

Extension Homepage
https://github.com/vvbogdanov87/gnome-shell-extension-kubeconfig

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class. 2. `lookupByUUID()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection). - line 19 kubePopupMenuItem.js - line 21 and 73 kubeIndicator.js 3. Please use `TextDecoder` instead of `byteArray`: - line 5 kubePopupMenuItem.js - line 8 kubeIndicator.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules 4. Don't use spawn command for opening prefs (line 62 kubeIndicator.js). You can send `this` from the entry point and use `extension.openPreferences()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils