Review of "Application Tabs" version 8

Details Page Preview

Panel will include a different window tab for the same application that is currently launched. 1. You can see the application window intuitively 2. Click tab to jump to or hide the corresponding window immediately. 3. Click the Close button to close the window. 4. Right click tab to show window function menu.

Extension Homepage
https://github.com/hhoao/app_tabs

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
# extension.js For `extension.js`, `lookupByUUID()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection). For example, in `enable()`: ```js this._tabs = new TabPanel({config: this._config}, this.getSettings()); ``` Now you can send that settings instance to `AppTab` too. # prefs.js For prefs, you should `this.getSettings()` in `fillPreferencesWindow()` and then send it to the methods needing that. ```js const settings = this.getSettings(); const ellipsize_mode_group = this.get_ellipsize_mode_group(settings); const app_tab_config_group = this.get_app_tab_config_group(window, settings); ``` that way, you will create the settings once. Wanna fix and send it again?
wong_howe posted a review
Ok, I willl fix it.
wong_howe auto- rejected
Auto-rejected because of new version 9 was uploaded