Review of "Application Tabs" version 8

Details Page Preview

Window tabs for the focused application in the GNOME top bar or on a draggable floating bar. • Panel mode: tabs in the top bar • Standalone mode: floating tab bar (optional hide top bar, slide animation) • Click tab to focus or minimize; close button and right-click window menu • Drag to reorder tabs; add-tab and recent-windows menus • Per-app fixed panel/standalone mode; customizable tab styles Questions and feature requests: repository issue tracker.

Extension Homepage
https://github.com/hhoao/app_tabs

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
# extension.js For `extension.js`, `lookupByUUID()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection). For example, in `enable()`: ```js this._tabs = new TabPanel({config: this._config}, this.getSettings()); ``` Now you can send that settings instance to `AppTab` too. # prefs.js For prefs, you should `this.getSettings()` in `fillPreferencesWindow()` and then send it to the methods needing that. ```js const settings = this.getSettings(); const ellipsize_mode_group = this.get_ellipsize_mode_group(settings); const app_tab_config_group = this.get_app_tab_config_group(window, settings); ``` that way, you will create the settings once. Wanna fix and send it again?
wong_howe posted a review
Ok, I willl fix it.
wong_howe auto- rejected
Auto-rejected because of new version 9 was uploaded