Review of "TeaTimer" version 3

Details Page Preview

A tea steeping timer Follow-up Fork of https://extensions.gnome.org/extension/604/teatime

Extension Homepage
https://github.com/zeners/gnome-shell-teatime/tree/teatimer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Rejected
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Inactive
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Same name as original: - `settings-schema` and `gettext-domain` in `metadata.json`. - schema's xml file name. - schema id and path. 2. Unnecessary imports (line 7, 10, 18 and 21 `extension.js`). 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 4. Better using `fillPreferencesWindow()` instead of `getPreferencesWidget()` for prefs. 5. Don't make it global (line 48-49 utils.js) if you don't want to null out on disable. 6. You cannot use `imports` in GNOME Shell 45 extensions (line 52 and 82 `utils.js`)