GNOME Shell Extensions

Review of "Switch Focus Type" version 13

Details Page Preview

Switch Focus Type

by r_mano

Toggle between focus-follow-mouse and click-to-focus mode

Extension Homepage
https://github.com/Rmano/gse-switch-focus-mode
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
Please null out `this._settings` in disable. [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)
r_mano posted a review
Thank you for the catch! Really, `this._settings` was not used, because I used `my_prefs` to store the settings. I read the page you linked to, and I think that I also forgot to disconnect the signal. I will upload another version shortly. Thanks!
JustPerfection posted a review
It's actually better to disconnect the signal but not really needed in that case since you are destroying and nulling that out.