Review of "Desktop Logo" version 1

Details Page Preview

Add a logo to the desktop. This is a fork of Background Logo extension https://extensions.gnome.org/extension/889/background-logo/

Extension Homepage
https://github.com/howbea/logo-widget

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Inactive
5 Inactive
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

howbeau posted a review
Hi This is a fork from Florian's Background Logo. Please tell me and stop publishing if there is something wrong.
JustPerfection rejected
1. You cannot have the same schema id, path and xml filename as the original extension: - [EGO Review Guidelines: schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) - [EGO Review Guidelines: metadata](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. `lookupByURL()` is a bad practice (line 56 `extension.js`). You can send `this.getSettings()` from the entry point to the class needing it when it's possible (dependency injection). 3. Extensions cannot use `run_dispose()` (line 264 `extension.js`): > This function should only be called from object system implementations. [gjs-docs: run_dispose](https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose) 4. Move line 275 `extension.js` to enable and null that out in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Please remove line 67-73 `prefs.js`. `GnomeDesktop` version 4 doesn't have `GnomeDesktop.BGSlideShow()` anyway. Also remove the import line 7. 6. Don't use `imports` (line 9 `prefs.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 7. Better to use `fillPreferencesWindow()` instead of `getPreferencesWidget()` (line 343 `prefs.js`). 8. You need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)