Review of "Fix focus on workspace switch" version 5

Details Page Preview

When a workspace switch occurs, this extension ensures the focus is on a window located in the new workspace. This extension is essential for a multi-monitor setup using multiple workspaces.

Extension Homepage
https://github.com/hiddn/fix-focus-on-workspace-switch

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. Wrong way of storing the signal id: line 46 `extension.js` should be: ```js this._wokrspaceSwitchedSignal = global.workspace_manager.connect('workspace-switched', _setFocus); ``` and line 53 should be: ```js global.workspace_manager.disconnect(this._wokrspaceSwitchedSignal); ``` 3. You are storing many timeouts in one variable (line 108 `extension.js`). All of those timeouts should be removed on disable. You only remove the last one.