Review of "xAzanTimes" version 1

Details Page Preview

Azan is an Islamic prayer times extension for Gnome Shell. It's a fork of the extension by faissaloo. For Gnome 46 check: https://extensions.gnome.org/extension/6997/athantimes/ Features - List compulsory prayer times - Optionally display Imsak, Sunrise, Sunset and Midnight - Show remaining time for the upcoming prayer. - Show current date in Hijri calendar. - Display a notification when it's time for prayer. - Automatic Geoclue2 location detection - Show times in 24 hour and 12 hour formats - Hijri date adjusment - Iqamah option

Extension Homepage
https://github.com/a7medkhalaf/azan-gnome-shell-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use `var`. Use `let` and `const` instead. 2. You need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Please remove `convenience.js`. You can use `this.getSettings()` in the entry point. 4. Also null out in disable: ```js azan = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. You cannot create instance of objects in the constructor (line 580 `PrayTimes.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 6. Remove `prefs-old.js` since you are not using it. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions