1. `let settings` not `settings` (line 23 `prefs.js`). anyway, better to attach it to window to avoid garbage collecting before window close: https://gjs.guide/extensions/development/preferences.html#prefs-js 2. Every property you hold in `this` should be destroyed null out in disable (line 8-20 `extension.js`). I recommend to move everything to another class to ease up the review process.

"I recommend to move everything to another class to ease up the review process" If I move them to another class say ClassA // in Extension class let props = new ClassA() // and I will use props.something instead of this.something but to destroy/null out everything do I just props = null // in destroy method is that it, instead of doing it individually unlike what I have done

Yeah :)