Review of "Draw On Your Screen 2" version 7

Details Page Preview

This is a fork from Abakk Draw On Your Screen. Start drawing with Super+Alt+D and save your beautiful work by taking a screenshot

Extension Homepage
https://github.com/zhrexl/DrawOnYourScreen2

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Inactive

Previous Reviews on this Version

zhrexl posted a review
JustPerfection rejected
1. No need to use `this.initTranslation()`: - line 85 `extension.js` - line 31 `prefs.js` > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. Move to enable and null that out in disable (line 86 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. This is 45 extension, so no need to version check: - line 90 `extension.js` - line 908 `menu.js` 4. Also null out in disable: ```js this.toggle = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. You cannot import `Gtk` and `Gdk` to the GNOME Shell process: - line 24 `files.js` - line 26 `menu.js` - line 31 `area.js` - line 25 `helper.js` [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 6. Please don't create instance of objects in global scope (line 25 `gimpPaletteParser.js`). 7. Extensions cannot use `run_dispose()` (line 235 `ui/drawingpage.js`): > This function should only be called from object system implementations. [gjs-docs: run_dispose](https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose) 8. Please don't use deprecated modules. Also you shouldn't use `imports` in 45 extensions (line 36 `helper.js`).