Review of "Window on Top" version 1

Details Page Preview

Simple top panel button for toggling Always on Top for windows.

Extension Homepage
https://github.com/uosyph/window-on-top

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. All properties inside the default class you are exporting need to be null out on disable. [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) I recommend to move out everything to another class and use the entry point to only create the instance of that class. 2. Signal should be disconnected on disable (line 73 `extension.js`). 3. Is this a fork? If so, you need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
btw, please use a less generic name for the default class you are exporting (for stack trace).