GNOME Shell Extensions

Review of "SerMon: Service Monitor" version 29

Details Page Preview

SerMon: Service Monitor

by rovellipaolo

SerMon: an extension for monitoring and managing systemd services, cron jobs, docker and podman containers

Extension Homepage
https://github.com/rovellipaolo/gnome-shell-extension-sermon
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
31 Active
30 Active
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You shouldn't create objects in the constructor (line 13 `prefs.js`). You can move that to `fillPreferencesWindow()` and null it out in window close request: [EGO Review Guidelines: initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 2. `lookupByUUID()` is a bad practice (line 25 `src/presentation/iconFactory.js`). You can pass the extension path to that function or you can simply get the dir name with: ```js GLib.path_get_dirname(import.meta.url); ```