Review of "Focusli" version 9

Details Page Preview

Improve focus and increase your productive by listening to different sounds

Extension Homepage
https://github.com/armonge/gnome-shell-extension-focusli

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Active
9 Rejected
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. We don't have 46 yet. So Please remove it. 2. What's the reason for line 16-17 `extension.js`? 3. Please don't use versions in the imports. 4. `lookupByUUID()` is a bad practice (line 63, 241 `extension.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 5. No need to use gst for playing sound. Use this instead: ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` 6. Calling functions in global scope is bad (line 204 `extension.js`). 7. Don't leave instance of objects in global scope after disable (line 86 `extension.js`). [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 8. I know this is transpiled TypeScript but that's making it harder to review. please make the final package easier the easier to review. 9. Please also null out `this.button` in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)