Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
1.1.4 (7) | Active |
1.1.3 (6) | Active |
1.1.2 (5) | Active |
1.1.1 (4) | Active |
1.1.0 (3) | Active |
1.0.0 (2) | Active |
1.0.0 (1) | Rejected |
1. Please remove versions from the imports. 2. Please don't store any instance in the class properties if you don't want to clean them up after window close (line 31-84 `prefs.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You have two options to fix that: a. Null them out on window close request. b. Don't store them in properties, instead, make them local to the methods and pass them to other methods. 3. Please don't do that in global scope (line 4 `utils/initResource.js`). [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 4. It will be much easier to review if you move the prefs modules to `prefs/` folder, so reviewers can know those modules only get loaded on `prefs.js` not shell process.
Hi, thanks for the review! Regarding point 4, I tried to load the resources in the fillPreferencesWindow method before, but because the templates for the custom widget needs the resource loaded before calling GObject.registerClass, I moved it to a seperate module and imported it before other modules. Should I move the GObject.registerClass calls to the fillPreferencesWindow method along with the resource intialization as well or is there a better alternative. Thanks!
I meant point 3* in the previous message.
AFAICS, yeah, if you do that in `fillPreferencesWindow()`, you shouldn't have any issues.