Review of "Mount Meter" version 2

Details Page Preview

Easily monitor and manage your mounted removable drives, displaying sizes and highlighting the mount with the least used space in the top bar. Forked and Modified extensively from Removable Drive Menu by fmuellner. Note:- 1.The list will automatically refresh every 5 seconds to provide updated information. 2.Any ongoing event(e.g. a file transfer) which result in changes(% used) in mount sizes will trigger the top bar indicator to highlight/flash until the file operation completes,this is intended and also partially doubles up as a file transfer operation indicator :)

Extension Homepage
https://github.com/dhariharan-05/gnome-shell-extension-mount-meter

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Hariharan D posted a review
Hi, I've made the changes: Removed stylesheet.css, sizeDisplay has been nulled out and timeout has been destroyed in disable. Regards, Hariharan D
JustPerfection rejected
`this._timeout` doesn't exist in `IndicatorExampleExtension`. You should do `this._indicator._stop()` instead but I recommend to do that in `Indicator.destroy()`.
Hariharan D posted a review
Hi, Sorry for overlooking that error, I get the `this._indicator._stop()` part but the recommendation confuses me slightly. Do you mean to have it this way inside the _indicator class, `destroy() { super.destroy(); if (this._timeout) { GLib.source_remove(this._timeout); } this._timeout = null; }` ?
JustPerfection posted a review
yes! but `super.destroy()` should be the last line of the `destroy()` method.
Hariharan D posted a review
Thanks for helping me out!! I have modified it now.