Review "Power profile indicator" version 1

Review of "Power profile indicator" version 1

Details Page Preview

Power profile indicator

by fthx

Add current power profile in panel's system icons. Very light extension.

Extension Homepage: https://github.com/fthx/power-profile

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
6	Active
5	Active
4	Active
3	Rejected
2	Active
1	Rejected

Previous Reviews on this Version

fthx posted a review January 7, 2024

Hi JP, The GS 45 one! You see that I did crawl in GS to shorten the code ;-) Hope all is ok, this time. ^^ More seriously, if you have a simple way to wait for Main.panel.statusArea['quickSettings']._powerProfiles.quickSettingsItems[0] to be ready instead of the timeout hack (that does work, though !), I'll be happy to get it. Thanks!

JustPerfection rejected January 9, 2024

Timeout should be removed on destroy (line 22 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Anyway, in this case, I prefer using `idle_add()` instead. If you used that, please also remove the `idle_add()` source id on destroy.