Review "SSH Search Provider Reborn" version 14

Review of "SSH Search Provider Reborn" version 14

Details Page Preview

SSH Search Provider Reborn

Provide SSH search results in overview. This is a fork of the original "SSH Search Provider", updated to work with newer Gnome-Shells.

Extension Homepage: https://github.com/F-i-f/ssh-search-provider

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
18	Active
17	Active
16	Active
15	Active
14	Rejected
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Rejected
1	Active

Previous Reviews on this Version

F-i-f posted a review January 9, 2024

Note that I have two versions of this extension currently under review, and I need them BOTH APPROVED. - 13 (other version), for GS 44 compatibility. - 14 (this version), for GS 45 compatibility. Thanks!

JustPerfection rejected January 10, 2024

1. Please don't store anything in the properties of the default class you are exporting (`prefs.js`), if you don't want to clean them up on window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) to solve that, make them local to `fillPreferencesWindow()`. Also attach settings to `window` to avoid garbage collection before window close: [Extension Guide: preferences](https://gjs.guide/extensions/development/preferences.html#prefs-js) 2. Please don't use `imports` in 45 extensions (line 30 `logger.js`). 3. Please don't use deprecated modules (line 24 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules)