Review of "Glasa" version 13

Details Page Preview

This extension puts adds an indicator to the top panel whose icon continuously renders two comic-like eyes that follow the mouse cursor.

Extension Homepage
https://github.com/lyrahgames/gnome-extension-glasa

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Rejected
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active
JustPerfection rejected
Don't store any property if you don't want to clean that up in window close request (line 17 `prefs.js`): EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)
lyrahgames posted a review
Thank you for the review. The link you gave me only describes this process for the main extension class. Could you tell me, how I can clean it up for the preferences class? I also thought that a variable initialized with `this.getSettings()` would not need to be destroyed as the documentation only nullifies it in the extension class: [GNOME Extension Preferences: Integrating Settings](https://gjs.guide/extensions/development/preferences.html#extension-js)
JustPerfection posted a review
You can make it local to `fillPreferencesWindow()` and pass it to the methods needing that. or you can: ```js window.connect('close-request', () => { // clean up here }); ```