Review of "Icon Grid Modifier" version 4

Details Page Preview

Change the number of Rows and Columns and to some extent change Icon size as well. I'll add more features soon Notes for reviewers: 1. this._gridModes line 71 and other lines is not my class's property, so it can't be accessed in disable(), so I can't set it to null like this._gridModes = null; But note that injectionmanager.clear() is enough for clearing the whole injection itself. It's also true for other properties like this.layout_manager, that are not mine (they're of target class) 2. The timeout setTimeout() in caller() method is used for to display a toast in UI (during this timeout toast displays in UI prefs.js). Timeout doesn't run on future runs, it's only meant to inform the user about which grid mode has been set and whether applied already or not, while user tries out different modes. User won't see the toast if I remove timeout. For user info the toast should be displayed, you might ask why not stop invoking overview.showApps() and display toast only, reason is that changes might not apply well while Appgrid is not invoked. if i immediately try to change gridMode without invoking AppGrid, it won't refresh at all! So timeout is necessary for user info.

Extension Homepage
https://github.com/Mou786Aha/Icon-Grid-Modifier-For-Gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You forgot to null out `this._injectionManager` after clear in disable. 2. About the timeout, you should remove the timeout on disable because they can get delayed. As we mentioned in the review guidelines: > Note that all sources MUST be removed in disable(), > even if the callback function will eventually return false > or GLib.SOURCE_REMOVE. [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Please don't add comments for reviewers in the metadata's description. and no need to add so many lines of comment to the code. Just replying under the review would be enough.