Review of "Emoji Copy" version 18

Details Page Preview

Emoji copy is a versatile extension designed to simplify emoji selection and clipboard management. It is a fork of Emoji Selector.

Extension Homepage
https://github.com/felipeftn/emoji-copy

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Rejected
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

FelipeFTN posted a review
Hello, JustPerfection! Thank you for your latest review of our new changes. I achieved to fix all the topics you send, I just have some questions here in my mind, and since you are a lot more experiment and comprehensive, I hope you could answer them right away. Is it allowed to turn the enable function from the Extension main class into async? I did some tests here, and it worked just fine, with no errors. I don't know how forbidden this action is - I hope it's not much hahaha Another thing, I could perform all of your requests but one. I understand your comprehension of the Gnome Extensions is just perfect, but I have some questions here about this suggestion you sent: - 4. If you want to send a third party library, don't use the minified version (`libs/sql/sql.js`); [EGO Review Guidelines: Obfuscated Code](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#code-must-not-be-obfuscated) Extension code MUST be readable and reviewable JavaScript. I know it is important to keep the extension code clean and understandable, no doubt on that. But the third party library is kinda a different thing. The non-minified code is recommended only for debug purposes by the code owners themselves. Using the non-minified version would directly impact the performance of the extension, since the non-minified code has more than 130k lines of Javascript code. I'm here to put my considerations over this topic of you to analyze it, since you have the mastery and complete understanding of the development of extensions, I know you will make the best decision, and we will follow through with it. Since it's a third party library, as I see, it is not a core part of the extension's code. Meaning that it was not written by the extension owner and its code should not be read, changed or debugged with time. It is a lot better for me, and the extension to run in the minified (production) version of the SQL.js library. My plea is that we can continue publishing the extension in this way, and in the future perhaps, find a better way to work with this library or some other. Thank you for your attention & help. - FelipeFTN
FelipeFTN auto- rejected
Auto-rejected because of new version 19 was uploaded