Review of "Night Light Slider Updated" version 5

Details Page Preview

Kiyui's Night Light Slider updated for GNOME 45. Provides a slider in the quick settings menu to control the night light temperature. Some nice options can be set in the extension preferences menu. Original implementation: https://codeberg.org/kiyui/gnome-shell-night-light-slider-extension/

Extension Homepage
https://codeberg.org/vilsbeg/night-light-slider-updated

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy: - line 116 `extension.js` - line 34 `convenience.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. GNOME Shell 45 supports `setInterval()` by default. no need to implement it again (line 38 `convenience.js`). 3. Move line 52, 60 and 61 to enable and null them out in disable: [EGO Review Guidelines: Only use initialization for static resources](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 4. Please fix the indentations in `extension.js`. Some lines using chars and some tabs. 5. Also null out in disable: ```js this._preferences = null; this._scheduler = null; this._settings = null; this._nightLight = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions