Review "Better End Session Dialog" version 2

Review of "Better End Session Dialog" version 2

Details Page Preview

Better End Session Dialog

by popov895

Show logout/reboot/shutdown together in the end session dialog

Extension Homepage: https://github.com/popov895/better-end-session-dialog

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
28	Active
27	Active
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Rejected
1	Active

Previous Reviews on this Version

JustPerfection rejected March 1, 2024

Please move line 12 `extension.js` to enable and null that out in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)

popov895 posted a review March 1, 2024

I made it similar to the example in the docs (see https://gjs.guide/extensions/topics/extension.html#injectionmanager), where an instance of InjectionManager isn't nullified. Maybe it's not necessary, because it will be reused in `enable()`? Besides, InjectionManager is a generic class and doesn't inherit from GObject.

JustPerfection posted a review March 1, 2024

I understand. That example should be fixed to follow EGO review guidelines.