Review of "20 20 20 Rule Timer" version 3

Details Page Preview

A GNOME extension timer to remind users to take breaks and reduce eye strain by following the 20'20'20 rule.

Extension Homepage
https://github.com/filippoberti2020/20-20-20-rule-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Number 3, 4 and 5 hasn't been addressed here from version 1 review. To fix that, please add this before line 37: ```js notificationTimeoutId = null; ``` Change line 18 to: ```js this._timeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1200000, () => { ``` and add this method to the `Indicator` class: ```js destroy() { if (this._timeoutId) { GLib.Source.remove(this._timeoutId); } super.destroy(); } ```