Review of "Fixed IME List" version 8

Details Page Preview

Prevent MRU re-sorting of IME list on switching input method so it will always be the same sequence as you set in Settings.

Extension Homepage
https://github.com/AlynxZhou/gnome-shell-extension-fixed-ime-list/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in the constructor (line 34 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) Move that line to enable and null it out in disable. 2. Also null out in disable: ```js this._activeSource = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)