Review of "BackSlide" version 29

Details Page Preview

Automatic background-image (wallpaper) slideshow for Gnome Shell

Extension Homepage
https://gitlab.com/p91paul/BackSlide

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
32 Unreviewed
31 Rejected
30 Rejected
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Rejected
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove line 176-181 `extension.js`, 73-81 `prefs.js`. Not needed. 2. Unused import (line 29 `prefs.js`). 3. You have `this.getSettings()` in the entry point. No need to use line 50-59 `settings.js`. 4. No need to use `this.initTranslation()` (line 41 `prefs.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 5. Don't store anything in global scope if you don't want to clean up after window close (line 42 `prefs.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 6. `this` is the current extension. no need to use line 58-60 `prefs.js`. 7. Use `console.*` instead of `print()` or `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 8. `lookupByURL()` is a bad practice (line 7 `utils.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 9. Don't use spawn command for opening the prefs window (line 76 `widgets.js`). You have `this.openPreferences()` in the entry point.